-
Notifications
You must be signed in to change notification settings - Fork 139
Refactor install scripts and add dockerfiles #1100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tengqm
reviewed
Feb 2, 2026
Darryl233
reviewed
Feb 2, 2026
Darryl233
reviewed
Feb 2, 2026
Darryl233
reviewed
Feb 2, 2026
Darryl233
reviewed
Feb 2, 2026
Darryl233
reviewed
Feb 2, 2026
Darryl233
reviewed
Feb 3, 2026
Darryl233
approved these changes
Feb 4, 2026
Collaborator
Darryl233
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
xmhubj
approved these changes
Feb 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CICD
PR Types
Improvemetns
PR Description
This pull request updates the CI/CD configuration to support a unified and flexible package manager/environment setup for functional tests, with a focus on future compatibility (e.g., for switching to
uvorpip), and temporarily disables some functional test jobs. The changes introduce new configuration options, refactor workflow inputs/outputs, and update environment activation logic to be package-manager agnostic.Key changes:
Package Manager and Environment Configuration
pkg_mgr,env_path,env_names) to.github/configs/cuda.yml, supportingpip,uv, andconda, with clear documentation for future transitions..github/workflows/all_tests_common.ymlto use genericpkg_mgr,env_name, andenv_pathvariables instead of hardcodedconda_envandconda_path, allowing for flexible environment handling.Functional Test Job Refactoring
functional_tests_hetero_train.ymlto use the newpkg_mgr,env_name, andenv_pathinputs, and refactored the environment activation logic to supportconda,uv, andpipusing a new utility script (pyenv_utils.sh).Temporary Disabling of Some Functional Tests
functional_tests_inference,functional_tests_serve, andfunctional_tests_rljobs inall_tests_common.yml, and removed their checks from theall_tests_completejob, with explanatory comments for future re-enabling.Cosmetic and Documentation Updates
.github/workflows/all_tests_cuda.ymlfrom "CUDA Tests Validation" to "cuda_tests" and added a comment about reading environment settings from the config file.These changes make the CI/CD system more modular, easier to maintain, and ready for future upgrades in package management.