Skip to content

Conversation

@aoyulong
Copy link
Contributor

@aoyulong aoyulong commented Jan 31, 2026

PR Category

CICD

PR Types

Improvemetns

PR Description

This pull request updates the CI/CD configuration to support a unified and flexible package manager/environment setup for functional tests, with a focus on future compatibility (e.g., for switching to uv or pip), and temporarily disables some functional test jobs. The changes introduce new configuration options, refactor workflow inputs/outputs, and update environment activation logic to be package-manager agnostic.

Key changes:

Package Manager and Environment Configuration

  • Added unified package manager configuration (pkg_mgr, env_path, env_names) to .github/configs/cuda.yml, supporting pip, uv, and conda, with clear documentation for future transitions.
  • Updated workflow inputs/outputs in .github/workflows/all_tests_common.yml to use generic pkg_mgr, env_name, and env_path variables instead of hardcoded conda_env and conda_path, allowing for flexible environment handling.

Functional Test Job Refactoring

  • Updated functional_tests_hetero_train.yml to use the new pkg_mgr, env_name, and env_path inputs, and refactored the environment activation logic to support conda, uv, and pip using a new utility script (pyenv_utils.sh).

Temporary Disabling of Some Functional Tests

  • Commented out (disabled) the functional_tests_inference, functional_tests_serve, and functional_tests_rl jobs in all_tests_common.yml, and removed their checks from the all_tests_complete job, with explanatory comments for future re-enabling.

Cosmetic and Documentation Updates

  • Renamed workflow in .github/workflows/all_tests_cuda.yml from "CUDA Tests Validation" to "cuda_tests" and added a comment about reading environment settings from the config file.

These changes make the CI/CD system more modular, easier to maintain, and ready for future upgrades in package management.

Copy link
Collaborator

@Darryl233 Darryl233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xmhubj xmhubj self-requested a review February 4, 2026 02:45
@aoyulong aoyulong merged commit acfef26 into flagos-ai:main Feb 4, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants